Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionGraphMorph is defined twice in two files. #6

Open
Kirtai opened this issue Dec 25, 2022 · 3 comments
Open

FunctionGraphMorph is defined twice in two files. #6

Kirtai opened this issue Dec 25, 2022 · 3 comments

Comments

@Kirtai
Copy link

Kirtai commented Dec 25, 2022

Both of the following files define FunctionGraphMorph.

Morphic-Widgets-Extras.pck.st
&
Examples-Morphic.pck.st

It would be neater and prevent version skew to have it in only one file.

@KenDickey
Copy link
Collaborator

KenDickey commented Dec 25, 2022

The Morphic README.md states that Morphic-Widgets-Extras is depricated.

Perhaps we need to revisit the idea of having an internal package marker for depricated packages (as with provide & require).

The package preflight check could pop-up a query indicating "the package _whateveris depricated, do you really want to use this?"

@KenDickey
Copy link
Collaborator

If the change is made to have a #depricated mark, perhaps we should also create a #prerelease mark with the same behavior.

I.e. in the preflight, the code would check first if a package is OK to load in the current sense (do the version check), then if either #depricated or #prerelease, then the user can select OK or Skip (keep looking for a package which satisfies the requirement or fail).

@Kirtai
Copy link
Author

Kirtai commented Dec 25, 2022

Ah, I see. I was just searching for a plotting morph and saw it come up in both files.

Yes, a #deprecated flag or something to mark a package as not to be used or as obsolete could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants