Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Heuristics to be editable per service in the UI #288

Open
cccs-rs opened this issue Dec 17, 2024 · 2 comments
Open

Allow Heuristics to be editable per service in the UI #288

cccs-rs opened this issue Dec 17, 2024 · 2 comments
Assignees
Labels
assess We still haven't decided if this will be worked on or not core enhancement New feature or request ui ui-frontend

Comments

@cccs-rs
Copy link
Contributor

cccs-rs commented Dec 17, 2024

Is your feature request related to a problem? Please describe.
It is possible the heuristic configurations per service isn't applicable or accurate to all deployments of Assemblyline. This can lead to issues such as submissions being under/over-scored than what's appropriate which can lead to FPs to be raised which can impact the triage part of Assemblyline.

Describe the solution you'd like
Let's allow administrators of the system to be able to modify/adjust the heuristic properties of a service for their deployment.
These changes should stick between updates and not be overridden on update.

Describe alternatives you've considered
Alternatives thus far would rely on either making a request for a change that impacts everyone globally or forking the service code and hosting it privately that you'd have to maintain to keep up with the origin.

@cccs-rs cccs-rs added enhancement New feature or request ui core ui-frontend assess We still haven't decided if this will be worked on or not labels Dec 17, 2024
@gdesmar
Copy link

gdesmar commented Dec 17, 2024

The alternative is using service parameters like Extract to set values for heuristics. In Extract, we allow customization of many thresholds for heuristic 16 and 22.
EDIT: If we can look at those customizations to give an idea of what we could want to customize, as it may not only be score related.

@sgaron-msft
Copy link

sgaron-msft commented Dec 17, 2024

Ideally this would all be done through the heuristic page so this is obvious the score we get when a heuristic fires and would be available for all heuristics for all service.

One more thing, it should probably also present the user with a "RESET" button indicating thing were changed.

This should probably be locked behind Admin or maybe signature management roles.

EDIT: Might be useful to be able to completely disable a heuristic as well from this interface change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assess We still haven't decided if this will be worked on or not core enhancement New feature or request ui ui-frontend
Projects
None yet
Development

No branches or pull requests

5 participants