-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version field to data saver/ loader metadata #751
Labels
Comments
@skrawcz , One thought is to provide for an overridable Callable object.
Source code as is currently implemented: Lines 53 to 72 in 427f523
|
Hmm -- this makes me think do we need schemas by type? Or can we have a general one on all dataframes, but where some fields might not be easily populated. |
skrawcz
added a commit
that referenced
this issue
Jul 18, 2024
Implements #751. This is to formalize schema at a Hamilton level. We can always extend this to have someone provide their own callback function to produce this.
7 tasks
skrawcz
added a commit
that referenced
this issue
Jul 18, 2024
Implements #751. This is to formalize schema at a Hamilton level. We can always extend this to have someone provide their own callback function to produce this.
elijahbenizzy
pushed a commit
that referenced
this issue
Sep 10, 2024
Implements #751. This is to formalize schema at a Hamilton level. We can always extend this to have someone provide their own callback function to produce this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The data save and loaders return metadata. We should version this schema so that we can iterate and make changes-- people can then know how to version/write code against it.
Describe the solution you'd like
Add a
__version__
field or something. It should follow semantic versioning. Major = breaking. Minor = new addition. Patch = bug fix.Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: