Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Stratify notebook does not produce non-directed stratification when asked #5205

Closed
dgauldie opened this issue Oct 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working Q&A Quality Assurance

Comments

@dgauldie
Copy link
Collaborator

  • Scenario:
  • Step:
  • Link to the project:

Describe the issue
A clear and concise description of what the bug is.

When asking the notebook to "Stratify my model by the ages young and old where young and old can become old, but old cannot become young" the resulting code block produces

model = stratify(
template_model=model,
key= "Age",
strata=['young', 'old'],
structure= [['young', 'old']],
directed=True,
cartesian_control=False,
modify_names=True,
concepts_to_stratify=None, #If none given, will stratify all concepts.
params_to_stratify= None, #If none given, will stratify all parameters.
param_renaming_uses_strata_names = True
)

directed should be False

Image

@dgauldie dgauldie added bug Something isn't working Q&A Quality Assurance labels Oct 18, 2024
@liunelson
Copy link
Member

A similar problem occurs in this issue:
#5286

I think this only requires a tweak to the code generation instructions. TBD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Q&A Quality Assurance
Projects
None yet
Development

No branches or pull requests

3 participants