Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve review process for community position #8

Open
bussec opened this issue Feb 26, 2020 · 4 comments
Open

Improve review process for community position #8

bussec opened this issue Feb 26, 2020 · 4 comments

Comments

@bussec
Copy link
Contributor

bussec commented Feb 26, 2020

Thing that I notices while reviewing the current position paper. Maybe we can improve the process for the next one ;-)

  • Comment process is single-line only
  • Comments only record committer, not author
  • Discussions cannot be reopened by normal users
  • Reformating across lines can be an issue as it requires users to adapt to Git
  • Process seems reasonable for a 300--500 word document, but for 12 kwords
@knarrff
Copy link
Collaborator

knarrff commented Feb 26, 2020

  • editing a patch is a little strange
  • recommendation for the future: put each sentence on a separate line, since comments are usually per line
  • long documents are per default hidden, and committing a change renews the view, hiding the previously unhidden document, making reviewing more difficult than is needs to be. Putting reviews in a queue works around this in some way, but isn't ideal either.

@knarrff
Copy link
Collaborator

knarrff commented Feb 26, 2020

  • sometimes, at least for me, the 'suggestion' option did not display the correct 'diff' when displayed later. Instead of a diff of the correct line, the '-' part was taken from an entirely different line of the document, making it look like the change was to edit the entire line. When viewing it, the 'suggestion' syntax was still fine and it also applied fine when accepting. This indicates that only the display had a problem, but this is still cumbersome when reviewing.

@sdruskat
Copy link
Contributor

Today:

image

@sdruskat
Copy link
Contributor

Set up rules for authorship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants