Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NotificationApplication #61

Open
mattdsmith89 opened this issue Feb 9, 2016 · 1 comment
Open

Rename NotificationApplication #61

mattdsmith89 opened this issue Feb 9, 2016 · 1 comment
Labels
refactoring

Comments

@mattdsmith89
Copy link
Contributor

The name of the NotificationApplication domain object doesn't fit with the rest of the domain. Since we now have ImportNotification it would make sense to rename NotificationApplication to ExportNotification.

The Notification schema in the database may also warrant an update, since the schema for the import notification is called Import (suggest Export for consistency),
@EliotJones
Copy link
Contributor

Duplicate of #62?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daveraine @EliotJones @mattdsmith89