From c85ca6cdc7501a96e55589216eb84ecd75bfe0ab Mon Sep 17 00:00:00 2001 From: Emanuele Danovaro Date: Wed, 6 Nov 2024 17:13:51 +0000 Subject: [PATCH 1/2] increased default value of socketOptionsListenBacklog --- src/eckit/net/SocketOptions.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/eckit/net/SocketOptions.cc b/src/eckit/net/SocketOptions.cc index 85338d2fa..e180c0e54 100644 --- a/src/eckit/net/SocketOptions.cc +++ b/src/eckit/net/SocketOptions.cc @@ -16,13 +16,9 @@ namespace eckit::net { static void init(SocketOptions& opts) { - static std::string bindAddr = Resource("localBindingAddress", ""); /* "127.0.0.1" */ - - opts.bindAddress(bindAddr); - - static int ListenBacklog = eckit::Resource("socketOptionsListenBacklog", 5); - opts.listenBacklog(ListenBacklog); + static std::string bindAddr = Resource("localBindingAddress", ""); /* "127.0.0.1" */ + static int ListenBacklog = eckit::Resource("socketOptionsListenBacklog", 128); static bool reusePort = eckit::Resource("socketOptionsReusePort", false); static bool reuseAddr = eckit::Resource("socketOptionsReuseAddr", false); @@ -34,6 +30,8 @@ static void init(SocketOptions& opts) { static int receiveBufferSize = eckit::Resource("socketOptionsReceiveBufferSize", 0); static int sendBufferSize = eckit::Resource("socketOptionsSendBufferSize", 0); + opts.bindAddress(bindAddr); + opts.listenBacklog(ListenBacklog); opts.reusePort(reusePort); opts.reuseAddr(reuseAddr); opts.noLinger(noLinger); From f12e52278dda6cda7bef6bcf2ce93482593d081b Mon Sep 17 00:00:00 2001 From: Emanuele Danovaro Date: Wed, 6 Nov 2024 22:04:55 +0000 Subject: [PATCH 2/2] listen backlog default set to SOMAXCONN --- src/eckit/net/SocketOptions.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/eckit/net/SocketOptions.cc b/src/eckit/net/SocketOptions.cc index e180c0e54..530ecf170 100644 --- a/src/eckit/net/SocketOptions.cc +++ b/src/eckit/net/SocketOptions.cc @@ -9,6 +9,7 @@ */ #include +#include #include "eckit/config/Resource.h" #include "eckit/net/SocketOptions.h" @@ -18,7 +19,7 @@ namespace eckit::net { static void init(SocketOptions& opts) { static std::string bindAddr = Resource("localBindingAddress", ""); /* "127.0.0.1" */ - static int ListenBacklog = eckit::Resource("socketOptionsListenBacklog", 128); + static int ListenBacklog = eckit::Resource("socketOptionsListenBacklog", SOMAXCONN); static bool reusePort = eckit::Resource("socketOptionsReusePort", false); static bool reuseAddr = eckit::Resource("socketOptionsReuseAddr", false);