[WIP] Debug methods for insertmanager #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need that right now? I would prefer to have (finally) #234 in, and then put this PR on top of that... |
martinalig
force-pushed
the
feature/update-debug-controller
branch
from
3dd66bd to
fcc5c78
Compare
|
SonarCloud Quality Gate failed.
|
|
Outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the debug controller is used by the calibration app, we update the controller to also use the
InsertManager. In order to allow certain debug only feature, a private constructor with a static instance getter function is added. The idea is, to prevent accidentally instantiating the wrong Manager. All functions, which are debug only are suffixed withDEBUGto help signalise a potentially error.If the debug instance of
InsertManageris used with the __NON__debug function, a warning is printed. Furthermore the function will raise a NullPointerException when the wrong instance is used with the wrong function, to prevent any potential problems of mixing.The debug instance of the
InsertManageris only used inWSProdConfigand removes filters related to JWTs.Closes: #242