Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support active Tibber subscription that is about to end #332

Closed
wants to merge 1 commit into from

Conversation

cybe
Copy link

@cybe cybe commented Jan 25, 2025

Hi,

I terminated my Tibber subscription for end of January. Right now, my subscription is active though. The API shows this as an ended status:

Request

{
  viewer {
    homes {
      currentSubscription {
        status
      }
    }
  }
}

Response:

{
  "data": {
    "viewer": {
      "homes": [
        {
          "currentSubscription": {
            "status": "ended"
          }
        }
      ]
    }
  }
}

I'm not sure what happens at the actual termination date. That is, what value will be given as status.

@cybe
Copy link
Author

cybe commented Jan 25, 2025

I just saw #274 . Strange. I get the status value ended since my app shows the information, that my subscription will end on January 29th. For about 3 weeks now.

@cybe cybe marked this pull request as draft January 26, 2025 06:17
@cybe
Copy link
Author

cybe commented Jan 26, 2025

Let's see what happens to the status once my subscription has actually ended.

By the way, to support statistics I also had to add ended to:

if subs[0].get("status") is not None and subs[0]["status"].lower() == "running":

@Danielhiversen
Copy link
Owner

has_active_subscription should not return True when status is ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants