Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type compatibility checking #7

Open
Darkyenus opened this issue Apr 28, 2014 · 3 comments
Open

Type compatibility checking #7

Darkyenus opened this issue Apr 28, 2014 · 3 comments
Labels
enhancement

Comments

@Darkyenus
Copy link
Owner

No description provided.

@AbigailBuccaneer
Copy link
Collaborator

It looks like there's already a significant quantity of code dedicated to this - as well as boolean GLSLType#isConvertibleTo(GLSLType), there's also a mass of code in GLSLOperator dedicated to generating lists of all possible compatible types for each operator. Which I think is the wrong way to go about it - it answers the question "what types can this operator handle?", rather than "given that this operator has these operands, is that valid and if so what's the resultant type?"

I'm currently adding uint/double/uvec/dvec/dmat support to the language and extending the existing GLSLOperator code to support these will be very laborious. I'm going to leave it for now but I think that the majority of the code in GLSLOperator will need replacing.

@Darkyenus
Copy link
Owner Author

I am all for simplification, I don't think that we need to know all possibilities.

@Darkyenus
Copy link
Owner Author

This commented code may be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AbigailBuccaneer @Darkyenus