Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package FANS automatically after every release #10

Open
IshaanDesai opened this issue Aug 26, 2024 · 3 comments
Open

Package FANS automatically after every release #10

IshaanDesai opened this issue Aug 26, 2024 · 3 comments
Assignees

Comments

@IshaanDesai
Copy link
Collaborator

FANS Debian packages can be generated and published after every release. This can be automated via a GitHub Action. A partial implementation exists already: https://github.com/DataAnalyticsEngineering/FANS/blob/develop/.github/workflows/build_and_package.yaml#L48-L59 and needs to be finalized.

@siggmo siggmo self-assigned this Aug 29, 2024
@siggmo
Copy link
Collaborator

siggmo commented Aug 29, 2024

I would work on this issue as well :)

I would again base my work on the preCICE counterpart if that's fine.

Some questions:

  • Should we also test the created packages? Like install them in a clean Ubuntu container and run the tests?
  • When should the workflow be run? Only when merging to main? Or also on PRs to main, when preparing the new release? Or even on develop already?

@IshaanDesai
Copy link
Collaborator Author

I would again base my work on the preCICE counterpart if that's fine.

Yes of course 😄

Should we also test the created packages? Like install them in a clean Ubuntu container and run the tests?

If possible yes. But this is usually hard to test, because it can be done only after packages are deployed.

When should the workflow be run? Only when merging to main? Or also on PRs to main, when preparing the new release? Or even on develop already?

I would suggest creating packages for every release (as the title of the issue says). @sanathkeshav would it be okay to have packages only for releases? This would ensure that anyone who installs FANS via a package manager will get a stable and working version.

@siggmo
Copy link
Collaborator

siggmo commented Sep 2, 2024

Should we also test the created packages? Like install them in a clean Ubuntu container and run the tests?

If possible yes. But this is usually hard to test, because it can be done only after packages are deployed.

We could create the packages and test them in the same action, and abort deployment when the tests fail, ...

When should the workflow be run? Only when merging to main? Or also on PRs to main, when preparing the new release? Or even on develop already?

I would suggest creating packages for every release (as the title of the issue says).

... that's why I thought it might make sense to run the package creation action before the release already. Maybe we can toggle the upload of the packages to only be done when the action runs in a release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants