From 873a4a14fdb2c23f1e742cc4d294437d484a5de1 Mon Sep 17 00:00:00 2001 From: Damien Mehala Date: Thu, 13 Feb 2025 12:15:25 +0100 Subject: [PATCH 1/2] fix(telemetry): only report configuration with known values --- packages/dd-trace/src/telemetry/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/dd-trace/src/telemetry/index.js b/packages/dd-trace/src/telemetry/index.js index 9328186a82a..ed9f88a9625 100644 --- a/packages/dd-trace/src/telemetry/index.js +++ b/packages/dd-trace/src/telemetry/index.js @@ -336,10 +336,14 @@ function updateConfig (changes, config) { const names = [] // list of config names whose values have been changed for (const change of changes) { + const { origin, value } = change + if (value === undefined) { + continue; + } + const name = nameMapping[change.name] || change.name names.push(name) - const { origin, value } = change const entry = { name, value, origin } if (namesNeedFormatting.has(entry.name)) { @@ -353,6 +357,7 @@ function updateConfig (changes, config) { } else if (Array.isArray(entry.value)) { entry.value = value.join(',') } + configuration.push(entry) } From 5aaa5b139b0bfae610c2ba22d311ec92110c5bcd Mon Sep 17 00:00:00 2001 From: Damien Mehala Date: Thu, 13 Feb 2025 15:40:41 +0100 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: simon-id --- packages/dd-trace/src/telemetry/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dd-trace/src/telemetry/index.js b/packages/dd-trace/src/telemetry/index.js index ed9f88a9625..a20d921077d 100644 --- a/packages/dd-trace/src/telemetry/index.js +++ b/packages/dd-trace/src/telemetry/index.js @@ -338,7 +338,7 @@ function updateConfig (changes, config) { for (const change of changes) { const { origin, value } = change if (value === undefined) { - continue; + continue } const name = nameMapping[change.name] || change.name