Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer Readme for Nixos Newbies #18

Closed
CrystalKeck27 opened this issue Dec 2, 2024 · 3 comments · Fixed by #28
Closed

Clearer Readme for Nixos Newbies #18

CrystalKeck27 opened this issue Dec 2, 2024 · 3 comments · Fixed by #28

Comments

@CrystalKeck27
Copy link

I think that this is probably obvious to people who use nixos more often, but it tripped me up for a good couple hours.

If you want to use the newrelic-infra service, there is another step on top of the overlay.

{
  pkgs,
  lib,
  inputs,
  ...
}: {

  imports =
    [
      inputs.nix-relic.nixosModules.newrelic-infra
    ];
  
  nixpkgs = {
    overlays = [
      inputs.nix-relic.overlays.additions
    ];
  };


  services.newrelic-infra = {
    enable = true;
    configFile = ./newrelic-infra.yml;
  };
}

I just include this file in my flake.

It would be nice if the readme had the imports statement somewhere in it too, but even if this change isn't made. I hope this issue helps anyone struggling with this in the future.

Don't forget to specialArgs = { inherit inputs; } in your flake.nix too.

@DavSanchez
Copy link
Owner

Hi!

You're totally right, sorry! I'll fix the documentation.

BTW, infrastructure-agent is upstreamed to Nixpkgs, so chances are you can skip the overlay and use it directly! It's both in 24.11 and unstable.

@DavSanchez DavSanchez linked a pull request Jan 25, 2025 that will close this issue
@DavSanchez
Copy link
Owner

Hello @CrystalKeck27! Sorry for the delay in addressing this. I have added some changes to the documentation in #28. Feel free to make a review or suggest any changes. I'll merge this later on the weekend if there are no comments.

@CrystalKeck27
Copy link
Author

Thank you for addressing this! The changes look good, feel free to close when the pr merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants