-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mujoco_ros_control getting reset while executing a plan causes execution to fail #3
Comments
Thanks for reporting this issue.
Our simulation can be reset by the user, which causes the ROS time to be reset to 0. This requires some special handling e.g. clearing message buffers among other things, because otherwise involved ROS components would ignore new messages with timestamps they have already seen. The log message present in your log is triggered when mujoco_ros_control detects that the current ROS time is older than the ROS time when it ran the last control update, concluding a time reset must have happened.
This should not happen unless a simulation reset is triggered manually and ROS time is reset. In both your logs the ROS time keeps incrementing, so no actual reset is triggered. We have to reproduce the issue on our side and backtrack the cause.
It seems the issue is rooted somewhere in mujoco_ros_control or mujoco_ros. The loaded scenario and difficulty setting should not make a difference here. We'll keep you posted. In the meantime, if you are able to pinpoint more details about when this error happens please report them in this issue. |
This helped, thanks! I might have gone overboard with the number of visualizations I had active:
With only Rviz open, plans get executed to completion every single time I tried. Interestingly, the real-time factor stayed around the same. My CPU is So I guess my follow-up question is: other than moving to another computer which has more hardware resources, is there anything else I can do to minimize/eliminate the chances of execution failing? It'd be a bummer for execution(s) to get preempted when, say, training a policy. To reproduce the problem I was facing:
|
As explained in ubi-agni/mujoco_ros_pkgs#20, this issue should be fixed by commit ubi-agni/mujoco_ros_pkgs@24a6154. I ran some tests and am rather sure you should not experience any more preempts because of this particular error, but I'll leave the issue open until you have tested the new version and confirmed that the fix works. |
Version 1.1 of the docker image was now added to the cloud you have been provided access to. Please let me know if everything now works for you or if you experience other issues. |
I can confirm version 1.1 does not have this problem. I verified with all my visualizations from before active and with 20 out of 32 cores stressed. Thank you for providing a new image with the hotfix. |
Hello , i am having problem integrating mujoco_ros_control pkg for control . How did you get it to work ? |
Successfully computed plans sometimes result in failed executions: execution begins but stops short of the goal with these logs:
When execution does proceed to completion, the logs are:
So
mujoco_ros_control
getting reset before execution completes is responsible for trajectory execution's status being reported as preempted, which does make sense. Why on some occasions doesmujoco_ros_control
get reset while an execution is underway? What is the "time reset" as stated in the log and what causes it?I've got
eval_mode
set tofalse
(anddifficulty_level
as1
, in case relevant but I'd be surprised if it is). I'm trying to move to a pose from the assembly_screw example:Any suggestions on how to overcome this or pointers on possible mistakes made by me would be very appreciated.
The text was updated successfully, but these errors were encountered: