From 4e350793e56e81cc66f376b70427b691138fe404 Mon Sep 17 00:00:00 2001 From: David Fong Date: Tue, 1 Nov 2022 19:07:36 +1100 Subject: [PATCH] fix warning message when editing and R >= 4.2.0 issue #36 --- DTedit.Rproj | 42 +++++++++++++++++++++--------------------- NEWS.md | 4 +++- R/dtedit.R | 2 +- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/DTedit.Rproj b/DTedit.Rproj index 79c70eb..4d650df 100644 --- a/DTedit.Rproj +++ b/DTedit.Rproj @@ -1,21 +1,21 @@ -Version: 1.0 - -RestoreWorkspace: Default -SaveWorkspace: Default -AlwaysSaveHistory: Default - -EnableCodeIndexing: Yes -UseSpacesForTab: Yes -NumSpacesForTab: 2 -Encoding: UTF-8 - -RnwWeave: Sweave -LaTeX: pdfLaTeX - -AutoAppendNewline: Yes -StripTrailingWhitespace: Yes - -BuildType: Package -PackageUseDevtools: Yes -PackageInstallArgs: --no-multiarch --with-keep.source --install-tests -PackageRoxygenize: rd,collate,namespace +Version: 1.0 + +RestoreWorkspace: Default +SaveWorkspace: Default +AlwaysSaveHistory: Default + +EnableCodeIndexing: Yes +UseSpacesForTab: Yes +NumSpacesForTab: 2 +Encoding: UTF-8 + +RnwWeave: Sweave +LaTeX: pdfLaTeX + +AutoAppendNewline: Yes +StripTrailingWhitespace: Yes + +BuildType: Package +PackageUseDevtools: Yes +PackageInstallArgs: --no-multiarch --with-keep.source --install-tests +PackageRoxygenize: rd,collate,namespace diff --git a/NEWS.md b/NEWS.md index 1bcfbe0..d43788e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -6,11 +6,13 @@ output: html_document --- ## DTedit 2.3.2 -13th November 2021 +1st November 2022 ### Bugfix * Better handling of tibbles. Convert to data.frame as soon as possible. +* Avoid warning message when editing row (issue #36), thanks @andresrcs + - fixed incorrect handling of options for selectize input-type variants ## DTedit 2.3.1 22nd October 2021 diff --git a/R/dtedit.R b/R/dtedit.R index a8594d3..45bead2 100644 --- a/R/dtedit.R +++ b/R/dtedit.R @@ -583,7 +583,7 @@ dteditmod <- function(input, output, session, # # returns a list of shiny inputs, 'fields' - if (grepl("selectize", inputTypes) && !is.null(selectize.options)) { + if (any(grepl("selectize", inputTypes)) && !is.null(selectize.options)) { # if *any* of the selectize input-type variants in the inputTypes # and selectize.options is actually defined #