Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle "ngh" in xifan hol mode properly #47

Open
De7vID opened this issue May 3, 2019 · 0 comments
Open

handle "ngh" in xifan hol mode properly #47

De7vID opened this issue May 3, 2019 · 0 comments

Comments

@De7vID
Copy link
Owner

De7vID commented May 3, 2019

The expandShorthand function can only expand "ngh" in one way, which means that it won't find both {n} + {gh} (as in {nenghep}) and {ng} + {H} (as in {vengHom}).

There's a workaround in PR #45 but it's not a real fix. It specifically looks for the entries in the database which have {ngH}, but requires updating if another such entry is added to the database.
dlyongemallo pushed a commit to dlyongemallo/klingon-assistant-android that referenced this issue Dec 16, 2020
@De7vID
Additional hack to handle {ngh} in xifan hol.
a3600a3 
See issue De7vID#47.
dlyongemallo pushed a commit to dlyongemallo/klingon-assistant-android that referenced this issue Dec 16, 2020
@De7vID
Additional hack to handle {ngh} in xifan hol.
80a5383 
See issue De7vID#47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@De7vID