Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled Makie artifacts #2015

Open
visr opened this issue Jan 20, 2025 · 1 comment
Open

Remove bundled Makie artifacts #2015

visr opened this issue Jan 20, 2025 · 1 comment
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Jan 20, 2025

From v2024.11.0 to v2025.1.0 the ribasim_windows.zip size grew from 230 MB to 313 MB.

We should investigate why and see if we can get it back to the old size. Presumably one of the Manifest.toml updates is responsible for this. The difference is entirely in the number of artifacts that get bundled, share\julia\artifacts\ used to be 10 directories but is now 55. I assume we don't need all those.

@github-project-automation github-project-automation bot moved this to To do in Ribasim Jan 20, 2025
@visr visr changed the title Binary size increase Remove bundled Makie artifacts Jan 20, 2025
@visr
Copy link
Member Author

visr commented Jan 20, 2025

Ribasim.jl has a weakdep on Makie.jl, meaning some plotting functions are only loaded if both Ribasim and Makie are loaded. I see the extra artifacts are Makie dependencies, for instance:

Makie -> FFMPEG_jll -> libaom_jll

Makie was already a weakdep during the last release, so I don't know if the new behavior comes from changes in PackageCompiler.jl or julia or something else. The project we are compiling in Ribasim.jl, which doesn't include Makie, so I would expect it to not bundle the Makie artifacts.

@visr visr added the core Issues related to the computational core in Julia label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia
Projects
Status: To do
Development

No branches or pull requests

1 participant