Issues with wflow clipping (initial states, gauge outlet, lake csv files)

[atsiokanos]

HydroMT-Wflow version checks

• I have checked that this issue has not already been reported.
• I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

(I can share an example on the Nile basin)

Current behaviour

1. When clipping a wflow model the instates are not clipped. Instead, they are copied and pasted as unclipped versions, which cannot be used by the model.

2. A gauge is not automatically placed at the outlet of the clipped model. Users must manually run an update command -c setup_outlets -v to address this.

3. Lake csv files (rating curves, e.g. lake_hq.csv) are not properly copied to the clipped version. In the clipped version, the csv contains "H" in first line and then instead of the water level and its corresponding DOY values it has only the first DOY value (under H) which ofc results in an error. Also these files can be copied to a clipped version without the specified lake.

Desired behaviour

instates.nc file must be clipped as well. Consider also placing a gauge automatically at the outlet of the clipped (sub)basin. Lake rating curves provided in a csv format should be copied properly. Ideally, a check should be done to verify whether the specified lake exists in the clipped version.

Additional context

No response

[hboisgon]

Thanks for reporting this issue @atsiokanos. Do you plan to solve it yourself in hydromt_wflow or do you want us to look into it? If so what is the priority/timelie you would like the issue to be fixed?

[atsiokanos]

thanks @hboisgon for your quick response! I have slightly updated the issue to include the bug with the lake CSV rating curves (see above). Unfortunately, at the moment, I don’t have the time and budget in my project to resolve it in hydromt_wflow. Fortunately, these issues are minor and can be fixed easily. While it’s not urgent, it is good to have it documented here.

[shartgring]

https://github.com/Deltares/hydromt/blob/v0.10.0/hydromt/cli/main.py#L634

[shartgring]

We have a clipped_states method now (https://deltares.github.io/hydromt_wflow/latest/_generated/hydromt_wflow.WflowModel.clip_states.html) so I think we would have to add that one to HydroMT core

For the tables and geoms, there is already some code there within WflowModel.clip_grid() indeed, so filtering on the new basin geometry might indeed be a quick implementation

[JoostBuitink]

Given that HydroMT-core (understandably) decided to drop support for the clip function through the CLI (Deltares/hydromt#1063), we should implement this fully in the plugin. This also gives the opportunity to improve the code and add stuff like inverse clipping as well!