From 96bcf3d15ccdcde38cf16f830ebf583abb4bf976 Mon Sep 17 00:00:00 2001 From: Ben Hollis Date: Tue, 17 Dec 2024 23:10:41 -0800 Subject: [PATCH] Remove react-test-renderer --- package.json | 2 - pnpm-lock.yaml | 33 -------- .../store-stats/AccountCurrencies.test.tsx | 80 ------------------- 3 files changed, 115 deletions(-) delete mode 100644 src/app/store-stats/AccountCurrencies.test.tsx diff --git a/package.json b/package.json index 44fa0b3f6..2b15b8cfd 100644 --- a/package.json +++ b/package.json @@ -105,7 +105,6 @@ "@types/react-beautiful-dnd": "^13.1.8", "@types/react-dnd-multi-backend": "^6.0.6", "@types/react-dom": "^18.3.5", - "@types/react-test-renderer": "^18.3.1", "@types/ua-parser-js": "^0.7.39", "@types/use-subscription": "^1.0.2", "@types/webpack": "^5.28.5", @@ -166,7 +165,6 @@ "prettier": "^3.4.2", "prettier-plugin-organize-imports": "^4.1.0", "react-refresh": "^0.16.0", - "react-test-renderer": "^18.3.1", "sass": "^1.83.0", "sass-loader": "^16.0.4", "source-map-loader": "^5.0.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7c2f6751e..9c1153816 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -244,9 +244,6 @@ devDependencies: '@types/react-dom': specifier: ^18.3.5 version: 18.3.5(@types/react@18.3.12) - '@types/react-test-renderer': - specifier: ^18.3.1 - version: 18.3.1 '@types/ua-parser-js': specifier: ^0.7.39 version: 0.7.39 @@ -427,9 +424,6 @@ devDependencies: react-refresh: specifier: ^0.16.0 version: 0.16.0 - react-test-renderer: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) sass: specifier: ^1.83.0 version: 1.83.0 @@ -4691,12 +4685,6 @@ packages: '@types/react': 18.3.12 dev: true - /@types/react-test-renderer@18.3.1: - resolution: {integrity: sha512-vAhnk0tG2eGa37lkU9+s5SoroCsRI08xnsWFiAXOuPH2jqzMbcXvKExXViPi1P5fIklDeCvXqyrdmipFaSkZrA==} - dependencies: - '@types/react': 18.3.12 - dev: true - /@types/react@18.3.12: resolution: {integrity: sha512-D2wOSq/d6Agt28q7rSI3jhU7G6aiuzljDGZ2hTZHIkrTLUI+AF3WMeKkEZ9nN2fkBAlcktT6vcZjDFiIhMYEQw==} dependencies: @@ -11996,27 +11984,6 @@ packages: turbo-stream: 2.4.0 dev: false - /react-shallow-renderer@16.15.0(react@18.3.1): - resolution: {integrity: sha512-oScf2FqQ9LFVQgA73vr86xl2NaOIX73rh+YFqcOp68CWj56tSfgtGKrEbyhCj0rSijyG9M1CYprTh39fBi5hzA==} - peerDependencies: - react: ^16.0.0 || ^17.0.0 || ^18.0.0 - dependencies: - object-assign: 4.1.1 - react: 18.3.1 - react-is: 18.3.1 - dev: true - - /react-test-renderer@18.3.1(react@18.3.1): - resolution: {integrity: sha512-KkAgygexHUkQqtvvx/otwxtuFu5cVjfzTCtjXLH9boS19/Nbtg84zS7wIQn39G8IlrhThBpQsMKkq5ZHZIYFXA==} - peerDependencies: - react: ^18.3.1 - dependencies: - react: 18.3.1 - react-is: 18.3.1 - react-shallow-renderer: 16.15.0(react@18.3.1) - scheduler: 0.23.2 - dev: true - /react-textarea-autosize@8.5.6(@types/react@18.3.12)(react@18.3.1): resolution: {integrity: sha512-aT3ioKXMa8f6zHYGebhbdMD2L00tKeRX1zuVuDx9YQK/JLLRSaSxq3ugECEmUB9z2kvk6bFSIoRHLkkUv0RJiw==} engines: {node: '>=10'} diff --git a/src/app/store-stats/AccountCurrencies.test.tsx b/src/app/store-stats/AccountCurrencies.test.tsx deleted file mode 100644 index 076641a74..000000000 --- a/src/app/store-stats/AccountCurrencies.test.tsx +++ /dev/null @@ -1,80 +0,0 @@ -import { AccountCurrency } from 'app/inventory/store-types'; -import { DestinyDisplayPropertiesDefinition } from 'bungie-api-ts/destiny2'; -import { useSelector } from 'react-redux'; -import renderer from 'react-test-renderer'; -import AccountCurrencies from './AccountCurrencies'; - -// Use the same display info for everything -const fakeDisplay: DestinyDisplayPropertiesDefinition = { - description: 'Used to convert an unlocked Warlock armor item to a universal ornament.', - name: 'Synthweave Bolt', - icon: '/common/destiny2_content/icons/182e59137a78545602c64f844b549bad.jpg', - iconSequences: [ - { - frames: [ - '/common/destiny2_content/icons/182e59137a78545602c64f844b549bad.jpg', - '/common/destiny2_content/icons/5c256c38ef115ca0257d6e2592a3643a.png', - ], - }, - ], - highResIcon: '', - hasIcon: true, -}; - -// Glimmer, legendary shards, silver -const basicCurrencies: AccountCurrency[] = [ - { - itemHash: 3159615086, - quantity: 102488, - displayProperties: fakeDisplay, - }, - { - itemHash: 1022552290, - quantity: 15777, - displayProperties: fakeDisplay, - }, - { - itemHash: 2817410917, - quantity: 8763, - displayProperties: fakeDisplay, - }, -]; - -const synthstuff: AccountCurrency[] = [ - { - itemHash: 4019412287, - quantity: 10, - displayProperties: fakeDisplay, - }, - { - itemHash: 4238733045, - quantity: 11, - displayProperties: fakeDisplay, - }, - { - itemHash: 1498161294, - quantity: 11, - displayProperties: fakeDisplay, - }, -]; - -jest.mock('react-redux', () => ({ - useSelector: jest.fn(), -})); - -/** Render some currencies and assert that the right number of icons are rendered */ -function testCurrencies(currencies: AccountCurrency[]) { - // This is a kind of hacky way to mock out redux - (useSelector as unknown as jest.Mock).mockReturnValue(currencies); - const tree = renderer.create(); - // We expect one image per currency - expect(tree.root.findAllByType('img').length).toBe(currencies.length); -} - -it('renders correctly with the basic currencies', () => { - testCurrencies(basicCurrencies); -}); - -it('renders correctly with the basic currencies and synth stuff', () => { - testCurrencies([...basicCurrencies, ...synthstuff]); -});