Armory doesn't display masterwork plugs in wishlists

[RenierZA]

DIM Version

Version 6.83.0 (release), built on 20/09/2021, 04:04:48

Browser Details

Microsoft Edge Version 93.0.961.52

OS Details

Windows 10

Describe the bug

I'm using the default voltron wishlist. I noticed on the new item detail popup that one of my Fatebringer rolls are shown in the wishlist, but it is not marked in DIM and the perks are not highlighted.

Here are the corresponding lines in voltron.txt:

// Fatebringer
//notes:PVP recommended roll: Full Bore (MKB)|tags:Sharditkeepit Community

dimwishlist:item=2171478765&perks=3250034553,106909392,3038247973,47981717,684616255
dimwishlist:item=2171478765&perks=202670084,106909392,3038247973,47981717,684616255

dimwishlist:item=2171478765&perks=3250034553,106909392,3038247973,47981717,2697220197
dimwishlist:item=2171478765&perks=202670084,106909392,3038247973,47981717,2697220197

It seems they also list the masterwork. Does that mean you have to have the correct masterwork for it show marked in DIM? The item detail popup does not show this on the rolls it is showing.

Logs

No response

[bhollis]

Hmm, I don't think having masterwork in a wishlist is a good idea.

[RenierZA]

Found another example:

// Fatebringer
//notes:Sharditkeepit Community: PVE recommended roll

dimwishlist:item=2171478765&perks=1482024992,106909392,3038247973,4104185692,684616255
dimwishlist:item=2171478765&perks=1482024992,106909392,3038247973,4104185692,178753455
dimwishlist:item=2171478765&perks=1482024992,106909392,3038247973,4104185692,2697220197
dimwishlist:item=2171478765&perks=1482024992,106909392,3038247973,4104185692,758092021

[nev-r]

It seems they also list the masterwork. Does that mean you have to have the correct masterwork for it show marked in DIM?

yes. thumbs ups are contingent on all things in a wishlist line matching

[48klocs]

Adding a little extra flavor, we do (did?) remove some odds and ends (shaders and ornaments, maybe MWs?) from URL-based imports, but expert mode lets you get as particular as you want.

This is why in the voltrons, I include recommended MWs in the notes rather than in the rolls.

[bhollis]

I think OP is claiming these rolls that include the masterwork are from voltron

[nev-r]

they are from voltron

[nev-r]

masterworks are almost precisely as impactful as barrels/mags/etc and are no more impactful on the number of permutations than barrels, so they have a completely rightful place in wishlists.
treating them as first class citizens of wishlists might actually help with not marking every dang gun as a 'godroll'

[RenierZA]

Even when you have the correct masterwork, it still won't mark the weapon unless you masterwork it all the way to 10. A masterwork below 10 has a different hash, and voltron only lists the hash masterwork=10.

Example:

Voltron.txt:

// Finite Impactor
//notes: sharditkeepit Community - PVP recommended roll - Eye of the Storm (Controller)
dimwishlist:item=3813153080&perks=1926090094,1885400500,1570042021,699525795,684616255
dimwishlist:item=3813153080&perks=1926090094,1885400500,1570042021,699525795,2697220197

My roll with range masterwork 4:
https://d2gunsmith.com/w/3813153080?s=1926090094,1885400500,1570042021,699525795,150943602,0

Voltron listing with range masterwork 10:
https://d2gunsmith.com/w/3813153080?s=1926090094,1885400500,1570042021,699525795,2697220197,0

Personally I would prefer an option to exclude masterwork. But if it's included then it's a problem that it won't show up until you fully masterwork it. The wishlist is there to help decide if you should fully masterwork it.

[delphiactual]

I'm sure I can throw something together in d2ai to make grouping of MW's (e.g. Level 1 - Level 10) happen, just need to figure out call it out on wishlist if desired.

[48klocs]

On the default list side of things, I removed the references to MW perks that were in there - sorry I didn't catch that the first time around.

Wish lists do support calling for MWs; I don't have strong feelings about them one way or another, but I'm not intentionally including them in the default lists until I update the form we recognize + translate the existing lists to be more JSON-y.

[bhollis]

Yeah we'd need a specific masterwork callout that recognizes all 9 masterwork mods for a stat without repeating the wishlist.

[RenierZA]

On the default list side of things, I removed the references to MW perks that were in there - sorry I didn't catch that the first time around.

Thank you very much. My wishlist matched items went from 130 to 139, including the examples above.

[bhollis]

As another twist, it appears that we aren't including the masterwork socket when building the item from definitions...

[bhollis]

We can consider adding "recommended masterwork" to DestinyItemManager/dim-api#70, but until that's adopted wishlists aren't going to support masterworks.