Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinchange interrupts could do with tidying up #322

Open
joemarshall opened this issue Feb 28, 2017 · 0 comments
Open

Pinchange interrupts could do with tidying up #322

joemarshall opened this issue Feb 28, 2017 · 0 comments

Comments

@joemarshall
Copy link
Contributor

There are several things that use (or probably should use) pinchange interrupts;

dust sensor,
flow sensor
encoder
ultrasonic read

They currently use a mix of polling, global pinchange PCINT2_vect, and pinchange on one pin (which only works on port 8). It would make sense for them all to sit on the global pinchange interrupts,
PCINT2_vect & PCINT0_vect . I would suggest we use the https://github.com/GreyGnome/EnableInterrupt library, as that does all the pinchange for all pins magic and would make it quite easy to translate the existing code.

I can't fix this because I don't have dust sensor, encoder or flow sensor to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant