Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelllists and Filters don't work anymore #97

Open
Aishuu87 opened this issue Sep 11, 2024 · 5 comments
Open

Spelllists and Filters don't work anymore #97

Aishuu87 opened this issue Sep 11, 2024 · 5 comments
Assignees
Labels
bug Something isn't working question Awaiting answer from reporter retail The War Within

Comments

@Aishuu87
Copy link

There are some weird interactions and bugs when you try to edit the spelllists. Adding spellID in a list doesn't work, as it keeps adding a different spellID that the one I'm trying to add. If I'm adding '#' before it, then the entire section is disappearing and I can't edit spelllists anymore.

It also doesn't work by adding spells one by one in the filter spell section.

For short, the entire filtering feature doesn't seem to work anymore

@Dicebar Dicebar self-assigned this Sep 12, 2024
@Dicebar Dicebar added bug Something isn't working question Awaiting answer from reporter labels Sep 12, 2024
@Dicebar
Copy link
Owner

Dicebar commented Sep 12, 2024

Could you fill in some details? Which spellIDs are you trying to add that get replaced? What are their replacements?

@Aishuu87
Copy link
Author

Sure !

On a fresh new Spell List and profile (because when it's bugged, the whole filter module is bugged)

  • I try to add : 344179 (maelstorm weapon from shaman)
  • It then freezes the entire UI for 2 sec and give me another unrelated icon
  • If I'm trying to add the hashtag before it it just simply makes the whole module disappear and can't interact with it anymore, I have to create another profile to make it show again

image
image
image
image

Hope it helps, let me know if I can provide more infos

@Dicebar Dicebar removed the question Awaiting answer from reporter label Sep 19, 2024
Dicebar added a commit that referenced this issue Sep 19, 2024
@Dicebar
Copy link
Owner

Dicebar commented Sep 19, 2024

Sooo...

A few things:

  • r683 should fix the spell list becoming inaccessible. That seems the most important problem to resolve right now.
  • 237584 is the IconID for Maelstrom Weapon. That's where it comes from, but I have to spend some time figuring out where that goes wrong.
  • When I add #344179 (so with hashtag) on my Shaman I get what seems like the correct icon:

image

It shouldn't be crashing there. Can you install BugGrabber and see what it throws out after installing r683?

@Dicebar Dicebar added the investigating Under investigation label Sep 20, 2024
@Dicebar Dicebar mentioned this issue Sep 20, 2024
@Dicebar
Copy link
Owner

Dicebar commented Sep 20, 2024

The bug with IconIDs has also been resolved.

Can you test r684 and see if all the problems you ran into have been resolved? Thanks!

@Dicebar Dicebar added retail The War Within question Awaiting answer from reporter and removed investigating Under investigation labels Sep 20, 2024
@Aishuu87
Copy link
Author

Hellll yes it's working again ! I tried adding stuff into spell lists, creating new ones, adding spellids directly to the filter section the buffs tabs of my bar group, and it's all working fine ! Thank you so much for fixing it !!

Is it possible that the addon is also lighter on the cpu thanks to your recent version ? It feels like the little lags I had entering combat are gone and overall more fps. Dunno if I'm hallucinating or not but it seems smoother and I didn't touch anything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Awaiting answer from reporter retail The War Within
Projects
None yet
Development

No branches or pull requests

2 participants