Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In component proposal-card change ViewCta from <button> to <a> #355

Open
crypto-supporter opened this issue Jun 30, 2019 · 0 comments
Open

In component proposal-card change ViewCta from <button> to <a> #355

crypto-supporter opened this issue Jun 30, 2019 · 0 comments

Comments

@crypto-supporter
Copy link
Contributor

crypto-supporter commented Jun 30, 2019 •
edited
Loading

governance-ui-components/src/components/proposal-card/style.js

Line 161 in a7b0559

export const ViewCta = styled(Button)`

For better UX and SEO links should always be an tag. If we change the "VIEW PROJECT" button to an a -tag this will improve:

UX:

  1. it will be possible to open proposals in a new tab by holding down cmd + clicking.
  2. the browser will show where an a-tag will take them in the lower left of the window .
  3. Better Accessibility for handicapped people using screen readers and such

SEO

The crawlers will crawl the site better if links are a-tags instead of button-tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crypto-supporter