Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG Logo Images for Header and Footer #2

Open
Tanya-ruby opened this issue Jan 16, 2025 · 1 comment
Open

Add SVG Logo Images for Header and Footer #2

Tanya-ruby opened this issue Jan 16, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Tanya-ruby
Copy link
Contributor

Context

Currently, the Header and Footer components use placeholder <img> tags to display the logo. Ideally, we want to replace these placeholders with a proper SVG logo for a more scalable and polished appearance.

Task

  1. Add an SVG logo file to src/assets/svg/. You can name the file logo.svg.
  2. Replace the placeholder <img> tags in the Header and Footer components with the newly added SVG logo.
  3. Ensure the SVG logo scales properly in its container.

File Locations

  • SVG File: src/assets/svg/logo.svg
  • Components to update:
    • src/sections/Header.tsx
    • src/sections/Footer.tsx

Steps to Complete

  1. Add the logo.svg file to the src/assets/svg/ directory.
  2. Import the SVG in the Header and Footer components using the following syntax:
    import Logo from '@/assets/svg/logo.svg';

Please attach a demo video,screenshots while making a PR ! ping the maintainer for further queries

@ceilican ceilican added the good first issue Good for newcomers label Jan 17, 2025
@Nidhicodes
Copy link

Demo.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants