-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to include what input Quantities are expected when using Pint #51
Comments
@rcaneill do we have any lingering concerns about pint support? Is TEOS-10/GSW-Python#97 an issue for how we did pint support? do we need to revert back to positional arguments when finally calling the upstream functions? |
I already implemented the reversion back to positional / keyword arguments when calling the upstream function: gsw-xarray/gsw_xarray/_core.py Lines 138 to 141 in ff552dd
I think this was done in PR #47 (hence closing issue #49) So we don't have any problems |
Oof, yep, failure on my part to notice that. 😞 I'll work on this issues (#51) and on some automated release stuff so we can release when things are tagged on GH. I'll probably use https://test.pypi.org/ while getting this set up. |
Great! I wanting to do it but never got time... |
Every time I think I'll have time to work on this... I seem to get delayed. Well I made sure to have some time today.
Other than doing the actual "release", is there anything else blocking 0.3.0? |
Great news! I think that the only thing missing before releasing is changing the changelog. |
Awesome, great catch. Here we go! 🤞 |
Looks to be... not broken! How do we update the conda forge version? |
I guess we just approve the PR made by the robot? |
Yes I think so |
Now that pint support has landed, the expected inputs should be documented on that big long list of functions with the attribute outputs.
I'd like to evaluate switching to the py:func sphinx domain for these functions.
The text was updated successfully, but these errors were encountered: