Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in axis specification #68

Open
jkosciessa opened this issue Dec 10, 2024 · 3 comments
Open

Consistency in axis specification #68

jkosciessa opened this issue Dec 10, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@jkosciessa
Copy link
Collaborator

Some of the axes may lack proper labels with respect to the original reference point.

  • The real profile is estimated from the exit plane of the transducer, but the simulation results usually include a large part of the transducer (confusingly, they do not start at the bottom of the transducer).
  • The OG calibration added the distance between [the bottom of the transducer bowl and the exit plane] to the real profile. In other words, what we used to plot on the x-axis wasn't the axial position from the exit plane, but from the bottom of the bowl.
@jkosciessa jkosciessa added the documentation Improvements or additions to documentation label Dec 10, 2024
@jkosciessa
Copy link
Collaborator Author

I am currently revising plot_isppa_over_image to add info on multiple axis points of the simulation, such that the expected output can be validated.

Screenshot 2024-12-10 at 12 26 50

@jkosciessa
Copy link
Collaborator Author

Added those updates along with a transducer_calibration function to a new branch reporting.

@jkosciessa
Copy link
Collaborator Author

Merged into development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant