Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not finding any results #652

Open
Isak-Kallini opened this issue Dec 15, 2024 · 6 comments
Open

Search not finding any results #652

Isak-Kallini opened this issue Dec 15, 2024 · 6 comments
Labels
bug Something isn't working as intended

Comments

@Isak-Kallini
Copy link
Member

Description

Search gives no results found when searching for stuff that should find something. It gets fixed after syncing from the debug page, but after a while (presumably after the daily sync?) it stops working again

Steps to reproduce

Try to search for something that should exist

Further information

No response

@Isak-Kallini Isak-Kallini added the bug Something isn't working as intended label Dec 15, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in CPU Dec 15, 2024
@danieladugyan
Copy link
Member

@alfredgrip any immediate thoughts?

@alfredgrip
Copy link
Contributor

Strange... but perhaps something to do with that the current timeout of 10 seconds is too short. I'll try to look in to it, but I suppose it's hard to debug

@alfredgrip
Copy link
Contributor

#653 might close this, but I guess we need to deploy it to actually test it and see if it works

@Isak-Kallini
Copy link
Member Author

Still not sure if this is fixed but I monitored the server while running the sync and found that it goes above the 200 MB memory limit while syncing. It still seems to be working though? I'm not really sure how the memory limit works

@alfredgrip
Copy link
Contributor

This could very well be the case. When the syncing happens A LOT of data from our database (all members, news, events, songs, positions and committees currently) gets loaded and sent to meilisearch. I guess it could be refactored to partition the data and sync some at a time.

@alfredgrip
Copy link
Contributor

#662 in combination with increasing memory usage in prod in 4ea4f7d seems to have fixed it. I monitored the memory usage during sync and it reached about 230MB (while the other instances were around 180MB), so the old limit of 200MB caused the instance to restart and thus aborting the sync halfway finished. I think this made it so that only some, say, member got synced to Meili, and that could be the reason why not all members showed up in search, i.e. the issue mentioned in #676

Still unsure how sync will be handled when 4 instances are running in parallel, but with non-unique IDs and higher memory usage I think it should be fine, but we should keep an eye on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants