Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onagent nodeaffinity #4253

Closed
wants to merge 6 commits into from
Closed

Onagent nodeaffinity #4253

wants to merge 6 commits into from

Conversation

bentastic27
Copy link

Description

Adds nodeAffinity options for the one agent daemonset. I need this to avoid "pending pods" on EKS clusters that have Fargate profiles.

Fixes #2427

How can this be tested?

Tested with the operator installed with version 1.4.0 of the chart and setting

spec:
  oneAgent:
    classicFullStack:
      nodeAffinity:
        requiredDuringSchedulingIgnoredDuringExecution:
          nodeSelectorTerms:
          - matchExpressions:
            - key: eks.amazonaws.com/compute-type
              operator: NotIn
              values: ["fargate"]

@bentastic27 bentastic27 requested a review from a team as a code owner January 3, 2025 13:51
@jbilliau-rcd
Copy link

I have a support ticket opened up about this as well, ticket #422097. Would be great to get this reviewed and released asap!

@chrismuellner
Copy link
Collaborator

We are planning on supporting nodeAffinity across all Operator core and managed components and doing this just for the Oneagent would leave us in an inconsistent state. It would need to be configurable in the Helm chart, managed components in the Dynakube/other CRs and documented accordingly in the official documentation.

Please add your support for this change to the RFE in the Dynatrace Community!

@jbilliau-rcd
Copy link

hey @chrismuellner , I actually already did in this comment - #4253 (comment)

There hasn't been any update on this since 05/2024...can we get a status of where it's at? Being evaluated, in progress, etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkrenn gkrenn Awaiting requested review from gkrenn gkrenn is a code owner automatically assigned from Dynatrace/kubernetes-operator

@0sewa0 0sewa0 Awaiting requested review from 0sewa0 0sewa0 is a code owner automatically assigned from Dynatrace/kubernetes-operator

@chrismuellner chrismuellner Awaiting requested review from chrismuellner chrismuellner is a code owner automatically assigned from Dynatrace/kubernetes-operator

@albertogdd albertogdd Awaiting requested review from albertogdd albertogdd is a code owner automatically assigned from Dynatrace/kubernetes-operator

@waodim waodim Awaiting requested review from waodim waodim is a code owner automatically assigned from Dynatrace/kubernetes-operator

@StefanHauth StefanHauth Awaiting requested review from StefanHauth StefanHauth is a code owner automatically assigned from Dynatrace/kubernetes-operator

@luhi-DT luhi-DT Awaiting requested review from luhi-DT luhi-DT is a code owner automatically assigned from Dynatrace/kubernetes-operator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add affinity support for DT oneAgent
3 participants
@bentastic27 @jbilliau-rcd @chrismuellner