Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The test modifier mach-pet is empty shell script and can be removed, but requires updating several test names #6880

Open
ndkeen opened this issue Jan 9, 2025 · 0 comments
Open

The test modifier mach-pet is empty shell script and can be removed, but requires updating several test names #6880

ndkeen opened this issue Jan 9, 2025 · 0 comments
Labels
BFB PR leaves answers BFB Machine Files Testing Anything related to unit/system tests

Comments

@ndkeen
Copy link
Contributor

ndkeen commented Jan 9, 2025

The modifier mach-pet was used for machine-specific changes to PET tests, but we have now removed those machines.
So we could simplify a few test names by removing the modifier and removing the empty shell script.
As it would change test names, and not currently hurting anything, it's not critical.
@ndkeen ndkeen added Machine Files Testing Anything related to unit/system tests BFB PR leaves answers BFB labels Jan 9, 2025
@ndkeen ndkeen changed the title The test modified mach-pet is empty shell script and can be removed, but requires updating several testnames The test modifier mach-pet is empty shell script and can be removed, but requires updating several test names Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BFB PR leaves answers BFB Machine Files Testing Anything related to unit/system tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndkeen