Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of nodes for tests to 1 node #41

Open
adammoody opened this issue Oct 27, 2021 · 3 comments
Open

reduce number of nodes for tests to 1 node #41

adammoody opened this issue Oct 27, 2021 · 3 comments

Comments

@adammoody
Copy link
Contributor

No description provided.

@adammoody
Copy link
Contributor Author

This one will take a bit more effort, because it uses hostname to define failure groups. This will need to be changed to some string that encodes a rank id or something instead.

@gonsie
Copy link
Member

gonsie commented Feb 4, 2022

which tests require more than 1 node? everything but single?

It looks like test_reset has 4 tests:

single
partner
xor
rs
We could put a simple MPI check before running the multi-node test. an all reduce (maybe comm split?) on the hostname. If we don't have multiple nodes we shouldn't run the tests.

alternatively, we could maybe put a toggle in to say whether we expect the test to pass or fail?

@adammoody
Copy link
Contributor Author

My hope is that we can rewrite the test program so that all of the tests can run on a single node, but we have some work to do to accomplish that, if it's possible. Until then, we can just keep things simple and assume that all tests require multiple nodes (even if a few don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants