Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Temporary Particle Container #5551

Closed
ax3l opened this issue Jan 10, 2025 · 1 comment
Closed

Remove Temporary Particle Container #5551

ax3l opened this issue Jan 10, 2025 · 1 comment
Assignees
@atmyers
Labels
cleaning Clean code, improve readability duplicate This issue or pull request already exists

Comments

@ax3l
Copy link
Member

ax3l commented Jan 10, 2025

We want to remove tmp_pc that was used in early days for init and particle splitting. It is not needed anymore to do this with a persistent container and it complicates bookkeeping, refactoring and maintenance, e.g. in #5015 to keep it. We can now just temporarily create PCs with the respective allocators when we need them.
@ax3l ax3l added the cleaning Clean code, improve readability label Jan 10, 2025
@ax3l
Copy link
Member Author

ax3l commented Jan 10, 2025

Duplicate of #5056

@ax3l ax3l marked this as a duplicate of #5056 Jan 10, 2025
@ax3l ax3l closed this as completed Jan 10, 2025
@ax3l ax3l added the duplicate This issue or pull request already exists label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atmyers atmyers

Labels
cleaning Clean code, improve readability duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ax3l @atmyers