-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to use plan_r2r of FFTW #4
Comments
@ptiede Yes this was the first thing I checked. I tested FFTW's r2r before pushing this to the public repository. I would note that FFTW's
It turns out that FFTW's implementation of multidimensional transform is not only inaccurate but also slow. I tested with 2 and 3 dimensional cases, and found that pure Julia implementation (basically using Having said that it is possible that we can force to use FFTW's r2r for one dimensional transform --- indeed for 1 dimensional case FFTW is slightly faster. I will think about that. At least I confirmed that my implementation is consistent with FFTW for 1 dimensional transform. |
Ahh makes sense! This looks good then! |
OK I have added an option to use r2r (ndim(A) > 1 will show a warn message). For 1d array, it will use FFTW's r2r transform as it is faster. |
I will close this issue as I have officially released the first version (which is now being registered to the Julia package repo). Feel free to open the issue again if needed. |
For FFTW it provides a built in Hartley transform with, its
r1r
function which may save time and memory. Did we want to use this instead?The text was updated successfully, but these errors were encountered: