Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcCF fix unexpected Subset variables #256

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

ChrisJohnNOAA
Copy link
Contributor

@ChrisJohnNOAA ChrisJohnNOAA commented Feb 11, 2025

Description

This removes the subset variables generated from source files being included in the dataset attributes at runtime. This is controlled by a new flag includeNcCFSubsetVariables that can be set in setup.xml

Fixes #180

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (doc changes pending merge of the big documentation rewrite)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ChrisJohnNOAA ChrisJohnNOAA merged commit 815b870 into ERDDAP:main Feb 20, 2025
1 check passed
@ChrisJohnNOAA ChrisJohnNOAA deleted the subsetVariables branch February 20, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected creation of subsetVariables attribute when loading a dataset
1 participant