Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccpp'ized ZM #66

Open
cacraigucar opened this issue Aug 11, 2023 · 0 comments · Fixed by #186
Open

Add ccpp'ized ZM #66

cacraigucar opened this issue Aug 11, 2023 · 0 comments · Fixed by #186
Assignees

Comments

@cacraigucar
Copy link
Collaborator

Add CCPP layers to ZM schemes

Use https://github.com/climbfuji/ccpp-physics/tree/feature/iap_dom as a guide

See: https://docs.google.com/document/d/1jHLVbUCUhdEtY8puVV5FRnnj0yWdlrrw7j1jpNBnMa4/edit for info on why it can not be used as a dropin

@cacraigucar cacraigucar self-assigned this Aug 11, 2023
cacraigucar added a commit that referenced this issue Jan 24, 2025
Originator(s): Cheryl Craig 

Tag: atmos_phys0_08_000

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):
Add ccpp'ized ZM - closes #66 

Describe any changes made to the namelist:
A       schemes/zhang_mcfarlane/zm_convr_namelist.xml
            - namelist template for ZM

List all files eliminated and why:  N/A


List all files added and what they do:
A       schemes/cloud_fraction/cloud_fraction_fice.F90
A       schemes/cloud_fraction/cloud_fraction_fice.meta
- Bring in the cloud_fraction_fice portion of the cloud_fraction CAM
code and CCPP'ize it

A       schemes/sima_diagnostics/zm_diagnostics.F90
A       schemes/sima_diagnostics/zm_diagnostics.meta
             - Add the main ZM diagnostics
             
A       schemes/sima_diagnostics/zm_convr_tendency_diagnostics.F90
A       schemes/sima_diagnostics/zm_convr_tendency_diagnostics.meta
A       schemes/sima_diagnostics/zm_evap_tendency_diagnostics.F90
A       schemes/sima_diagnostics/zm_evap_tendency_diagnostics.meta
A       schemes/sima_diagnostics/zm_momtran_tendency_diagnostics.F90
A       schemes/sima_diagnostics/zm_momtran_tendency_diagnostics.meta
A       schemes/sima_diagnostics/zm_tendency_diagnostics.F90
A       schemes/sima_diagnostics/zm_tendency_diagnostics.meta
             - Add ZM tendency diagnostics for each ZM component

A       schemes/utilities/to_be_ccppized_temporary.F90
A       schemes/utilities/to_be_ccppized_temporary.meta
- Add a temporary routine to house init methods which aren't being run
with to_be_ccppized code.
             - Add a call to wv_sat_init
             
A       schemes/zhang_mcfarlane/set_deep_conv_fluxes_to_general.F90
A       schemes/zhang_mcfarlane/set_deep_conv_fluxes_to_general.meta
A       schemes/zhang_mcfarlane/set_general_conv_fluxes_to_deep.F90
A       schemes/zhang_mcfarlane/set_general_conv_fluxes_to_deep.meta
- Add interstitials to move variables back and forth from the ZM deep
variables to general variables for the ZM routine which is used in
shallow convection as well
           
A       test/test_suites/suite_zhang_mcfarlane.xml
             - Suite to test ZM
             
A       to_be_ccppized/error_messages.F90
A       to_be_ccppized/namelist_utils.F90
A       to_be_ccppized/wv_sat_methods.F90
A       to_be_ccppized/wv_saturation.F90
- Add methods which ZM requires, but are not being CCPP-ized at this
point in time

List all existing files that have been modified, and describe the
changes:
(Helpful git command: git diff --name-status
development...<your_branch_name>)
M       doc/ChangeLog
M       doc/NamesNotInDictionary.txt
              - updated with ZM names

M       schemes/zhang_mcfarlane/zm_conv_convtran.F90
M       schemes/zhang_mcfarlane/zm_conv_convtran.meta
M       schemes/zhang_mcfarlane/zm_conv_evap.F90
M       schemes/zhang_mcfarlane/zm_conv_evap.meta
M       schemes/zhang_mcfarlane/zm_conv_momtran.F90
M       schemes/zhang_mcfarlane/zm_conv_momtran.meta
M       schemes/zhang_mcfarlane/zm_convr.F90
M       schemes/zhang_mcfarlane/zm_convr.meta
             - Further refinements needed to CCPP'ize ZM
             
M       suites/suite_cam7.xml
             - Add ZM routines to CAM7

List any test failures:

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc?
- CCPP'ized ZM which was a package which already existed in CAM

---------

Co-authored-by: Jesse Nusbaumer <[email protected]>
Co-authored-by: Haipeng Lin <[email protected]>
Co-authored-by: mwaxmonsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant