Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mapping to Arrays of Structs #362

Open
lydiagarms opened this issue Jan 10, 2025 · 0 comments
Open

Support Mapping to Arrays of Structs #362

lydiagarms opened this issue Jan 10, 2025 · 0 comments

Comments

@lydiagarms
Copy link
Contributor

Overview

Currently Mapping to Arrays of Structs have not been tested in starlight and are not fully supported.

Tasks

Fix all errors in the TieredPricing.zol contract, including for commitment recovery.
Create test contracts that should pass successfully in order for Mapping to Arrays of Structs to be supported.
Test all these test contracts (including commitment recovery) and fix any errors that arise.
There is an old now probably incompatible PR that seems to deal with this issue, close this upon finishing.

Optional

No optional element.

Definition of done

There should be test contracts added to the action tests for Mappings to Arrays of Structs. TieredPricing as well as all new test contracts should run successfully, included commitment recovery.

Links

This old PR dealt with something similar but may now be incompatible:
#194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant