Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Migrate auth screens to Jetpack Compose #585

Open
4 of 10 tasks
Tracked by #368
EdricChan03 opened this issue Mar 13, 2024 · 0 comments
Open
4 of 10 tasks
Tracked by #368

[Refactor] Migrate auth screens to Jetpack Compose #585

EdricChan03 opened this issue Mar 13, 2024 · 0 comments
Assignees
@EdricChan03
Labels
comp: arch Issues/PRs related to the app's architecture. enhancement Enhancements to the Android app. For the web version, please use the other repo instead. in progress PRs that are still not finished yet and/ or not yet ready for merging. migration Issues/PRs for long-term changes to be made
Milestone
The Great Rewrite

Comments

@EdricChan03
Copy link
Owner

EdricChan03 commented Mar 13, 2024 •
edited
Loading

Sub-issue for #368, tracking the auth screens migration to Jetpack Compose.

Tasks

  • Migrate activities to Jetpack Compose
    • LoginActivity
    • RegisterActivity
    • ForgotPasswordActivity
    • AccountActivity
  • Expose common auth composables (ProfileImage, AccountInfoRow, AuthRequiredDialog)
  • Expose common auth text-fields (email, password)
  • Expose common CompositionLocals (LocalCurrentUser, LocalIsSignedIn? - tentative naming)
  • Expose auth navigation graph (Migrate to Jetpack Navigation #456)
    • Remove activities (see above)
@EdricChan03 EdricChan03 added enhancement Enhancements to the Android app. For the web version, please use the other repo instead. in progress PRs that are still not finished yet and/ or not yet ready for merging. comp: arch Issues/PRs related to the app's architecture. migration Issues/PRs for long-term changes to be made labels Mar 13, 2024
@EdricChan03 EdricChan03 added this to the v1.1.0 milestone Mar 13, 2024
@EdricChan03 EdricChan03 self-assigned this Mar 13, 2024
@EdricChan03 EdricChan03 modified the milestones: v1.1.0, The Great Rewrite Mar 14, 2024
EdricChan03 added a commit that referenced this issue Apr 16, 2024
@EdricChan03
Add CompositionLocals for Firebase auth user data
ae690e0 
See #368 and #585

* Scaffold `:core:auth:compose` module
* Include module in settings script
* Add composable to provide CompositionLocals
@EdricChan03 EdricChan03 mentioned this issue Apr 23, 2024
Open
17 tasks
EdricChan03 added a commit that referenced this issue Jun 9, 2024
@EdricChan03
Move :core:auth:compose to :core:auth:ui:compose
ffe4a3a 
For #369 and #585
@EdricChan03 EdricChan03 mentioned this issue Jul 7, 2024
Open
18 tasks
EdricChan03 added a commit that referenced this issue Dec 19, 2024
@EdricChan03
Add common AuthRequiredDialog composable (#585)
3aa212d 
It does what it says on the tin

* Add common auth-related strings
* Scaffold `:core:auth:ui:common` module
* Include module in settings script
EdricChan03 added a commit that referenced this issue Dec 19, 2024
@EdricChan03
Add common ProfileImage composable (#585)
148ffbb 
* Add Coil Compose + Zoomable dependencies
* Add content description string
EdricChan03 added a commit that referenced this issue Dec 19, 2024
@EdricChan03
Add common AccountInfoRow composable (#585)
691bfd7 
* Add string for default display name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdricChan03 EdricChan03

Labels
comp: arch Issues/PRs related to the app's architecture. enhancement Enhancements to the Android app. For the web version, please use the other repo instead. in progress PRs that are still not finished yet and/ or not yet ready for merging. migration Issues/PRs for long-term changes to be made
Projects
StudyBuddy
Status: Backlog
Milestone
The Great Rewrite
Development

No branches or pull requests
1 participant
@EdricChan03