diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 46b98877a..da8f2a8db 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -30,6 +30,8 @@ Otherwise please check these points when getting a PR done: - [ ] I fully described what my PR does in the documentation (not in the PR description) - [ ] I fixed all affected documentation +- [ ] I fixed the introduction tour +- [ ] I wrote migrations in a way that they are compatible with already present data - [ ] I fixed all affected decisions - [ ] I added unit tests for my code - [ ] I added code comments, logging, and assertions as appropriate diff --git a/doc/meetings/2023_07_25.md b/doc/meetings/2023_07_25.md index d93803a6f..0b6528ed6 100644 --- a/doc/meetings/2023_07_25.md +++ b/doc/meetings/2023_07_25.md @@ -58,11 +58,14 @@ PermaplanT - submissions: - review more texts - self-merge PRs - - American English vs. British English + - [American English](../guidelines/documentation.md) vs. British English - related work: "uniqueness", compare with others - Entwicklung: - richtige Einstellung: keine Arbeit als lästig deklarieren - richtige Anstrengung: nicht zu viel (anspannung), aber auch nicht zu wenig (täglich weitermachen) +- further points to consider for every PR: + - migrations should not remove any data and should be compatible from now on + - introduction tour might need updates - Abschluss Code Reading - case study - user study