Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios error #83

Closed
garrettboatman opened this issue Nov 20, 2019 · 3 comments
Closed

Axios error #83

garrettboatman opened this issue Nov 20, 2019 · 3 comments
Labels

Comments

@garrettboatman
Copy link

Everything appears to be working, but all of my team gets this axios error after yarn start or yarn deploy.

Screen Shot 2019-11-20 at 11 26 15 AM

(node:35580) UnhandledPromiseRejectionWarning: Error: Request failed with status code 404
    at createError (/Users/garrettboatman/repos/byte-www/node_modules/axios/lib/core/createError.js:16:15)
    at settle (/Users/garrettboatman/repos/byte-www/node_modules/axios/lib/core/settle.js:18:12)
    at IncomingMessage.handleStreamEnd (/Users/garrettboatman/repos/byte-www/node_modules/axios/lib/adapters/http.js:201:11)
    at IncomingMessage.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1092:12)

Any ideas?

@Cam
Copy link
Member

Cam commented Nov 20, 2019

Hey @garrettboatman. We're getting the same error with the current build.

This is an issue with Slate Analytics. You can see the relevant issue at Shopify/slate#1075

This issue includes a fix that is quite suitable until a new version is shipped. Essentially you should change line 95 of node_modules/@shopify/slate-analytics/index.js to return axios('https://v.shopify.com/slate/track', axiosConfig).catch(() => {});. This ensures the script will bail silently if there is an error.

@Cam Cam added the bug 🐞 label Nov 20, 2019
@garrettboatman
Copy link
Author

@Cam Thank you! I couldn't find that Slate gh issue.

and thanks for the quick fix tip 🙂

@Cam
Copy link
Member

Cam commented Nov 21, 2019

@garrettboatman no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants