Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0.0-beta.2- Referencing Constitutional Committee Credentials as Keys #683

Closed
Ryun1 opened this issue Aug 26, 2024 · 1 comment
Closed
Milestone

Comments

@Ryun1
Copy link

Ryun1 commented Aug 26, 2024

Using "@emurgo/cardano-serialization-lib-asmjs": "^12.0.0-beta.2"

What?

Throughout the library, Constitutional Committee Credentials are referenced as keys

For example;

  • Within class CommitteeColdResign
  • There is the method committee_cold_key() which returns a credential NOT a key
  • This should probably be renamed to committee_cold_credential()

Why is it an issue?

A credential can be key-based OR script-based
So should be referenced as a Credential within method/variable names
Otherwise this could cause confusion

@lisicky lisicky added this to the 12.0.0 milestone Aug 28, 2024
@lisicky
Copy link
Contributor

lisicky commented Aug 28, 2024

Thanks @Ryun1! Fixed in the CSL 12.0.0

@lisicky lisicky closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@lisicky @Ryun1 and others