Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add preference center link to footer #1566

Merged
merged 10 commits into from
Jan 23, 2025
Merged

feat: add preference center link to footer #1566

merged 10 commits into from
Jan 23, 2025

Conversation

hroth1994
Copy link
Contributor

@hroth1994 hroth1994 commented Dec 23, 2024 •
edited
Loading

🔗 Linked issue

https://energysage.atlassian.net/browse/CED-2034

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Left align legal links
  • Add link for “Your privacy choices” that opens the cookie preferences center. It is prefixed by the CCPA icon to the left and has alt text of “California Consumer Privacy Act (CCPA) Opt-Out Icon”.

🥼 Testing

  • Tested by linking es-cms-pages to es-ds-components and opening localhost:8700 in GTM preview mode and clicking the “Your privacy choices” link.

🧐 Feedback Requested / Focus Areas

  • General

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@hroth1994 hroth1994 changed the title feat: add cookie notice and preference center links to footer feat: add preference center link to footer Jan 13, 2025
@hroth1994 hroth1994 marked this pull request as ready for review January 13, 2025 21:58
@nathanielwarner
Copy link
Collaborator

👀

nathanielwarner
nathanielwarner requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good! Nice work on the layout change, and I verified that it works in the GTM preview as well

es-ds-components/components/icon/ccpa-opt-out.vue Outdated Show resolved Hide resolved
nathanielwarner
nathanielwarner approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

ericdouglaspratt
ericdouglaspratt approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It stood out to me that the icon wasn't part of the link, and that clicking the icon did not do anything. I found that Microsoft's icon on microsoft.com includes the icon in the link.

However, I did some research and couldn't find any specific requirement that the icon be part of the link, and from an accessibility standpoint, a link that reads out "Your privacy choices" is probably much clearer than a link that reads out "California Consumer Privacy Act (CCPA) Opt-Out Icon Your privacy choices", so I'm okay with this as is.

@hroth1994 hroth1994 merged commit d7afa5f into esds-3.0-vue3-primevue Jan 23, 2025
1 check passed
@hroth1994 hroth1994 deleted the ced-2034-add-footer-links branch January 23, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielwarner nathanielwarner nathanielwarner approved these changes

@ericdouglaspratt ericdouglaspratt ericdouglaspratt approved these changes

@tomleo tomleo Awaiting requested review from tomleo tomleo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hroth1994 @nathanielwarner @tomleo @ericdouglaspratt