Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fly command no checking permission after map change. #202

Open
LadyCailinBot opened this issue May 23, 2013 · 11 comments
Open

fly command no checking permission after map change. #202

LadyCailinBot opened this issue May 23, 2013 · 11 comments

Comments

@LadyCailinBot
Copy link

CMDBOOK-2269 - Reported by RustyDagger

The title pretty much explains it, Currently if you enable fly in a map where you have permission then change map to where you don't have permission you can still fly. surly bukkit provides some way to detect a map change and acting on that would only be trivial. I am sure there are many server owners that would much like to have /fly usable on a player level much like I would. its nice to have on a building map but exploitable on a pvp level.

if the above cant be done can some kind of non toggle command be added to allow me to force it off using a command block currently i can only run /fly on a player and that could either turn it off or on.. maybe /fly name off

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

http://builds.enginehub.org/job/commandbook/5452

Try this build.

The permission "commandbook.flight." is needed to keep the current flight mode when changing worlds if this setting is enabled (it's on by default)

@LadyCailinBot
Copy link
Author

Comment by RustyDagger

sadly I am unable to test it because I am on a modded server and all the builds after the UUID support was added do not work on my 1.6.4 server. I am stuck running older builds of worldedit and commandbook.

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

Hm, I see, I may be able to make a back ported version of CommandBook for 1.6.4.

@LadyCailinBot
Copy link
Author

Comment by sk89q

Can add a class that will fallback to 1.6.4 code if 1.7 code is not present.

@LadyCailinBot
Copy link
Author

Comment by RustyDagger

That would be helpful Some major bugs have been fixed after the builds i am using it would be nice to Update. I'm sure that there are many more modded servers in the same boat. Al tho a lot of them are 12 ies running essentials...

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

Well, the problem is that there are some major changes which rely on the 1.7 code, such as the way in which CommandBook stores sessions, and a reinvented bans API... Combined... simultaneous compatibility is almost impossible without significant work, and more breaking changes. A back port seems more time efficient... I'll play around and see what I can do about reverting the UUID stuff while maintaining new features.

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

@RustyDagger if you're interested in testing a pretty much completely untested back port, you can try this build and tell me how it goes http://builds.enginehub.org/job/commandbook?branch=2-4-1.6.4.

The only thing that I could foresee being incorrectly merged is the bans updates. Everything else cleanly reverted.

@LadyCailinBot
Copy link
Author

Comment by RustyDagger

seems to be running fine dark_arc. Will give it a better test over the next few hours when i allow players on the server.

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

Alright great, in regards to your original unedited comment, there shouldn't be any multi homes support. I haven't begun implementing that in any branch.

@LadyCailinBot
Copy link
Author

Comment by RustyDagger

dam it you seen that I realized I was derping with owner commands. creating homes for other players.

@LadyCailinBot
Copy link
Author

Comment by Dark_Arc

Haha, it's fine -- I get emails for CommandBook issues. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant