Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification of ebi_biomes.csv #735

Closed
kaiiam opened this issue Mar 22, 2019 · 1 comment
Closed

modification of ebi_biomes.csv #735

kaiiam opened this issue Mar 22, 2019 · 1 comment
Assignees
@cmungall
Labels
GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary

Comments

@kaiiam
Copy link
Contributor

kaiiam commented Mar 22, 2019

As mentioned in #672, my understanding is that I should update the ebi_biomes.csv to make use of the oboInOwl iri: http://www.geneontology.org/formats/oboInOwl#hasDbXref to reference the currently existing EBI biome iri's. For the first example class rather than root > Environmental > Aquatic > Freshwater > Ice > Glacial lake

it should be https://www.ebi.ac.uk/metagenomics/browse?lineage=root:Environmental:Aquatic:Freshwater:Ice:Glacial lake

Such that the last column in the ebi_biomes.csv should changed to the following:

EBI Biome Path

A http://www.geneontology.org/formats/oboInOwl#hasDbXref
https://www.ebi.ac.uk/metagenomics/browse?lineage=root:Environmental:Aquatic:Freshwater:Ice:Glacial%20lake

Is this correct?
kaiiam added a commit that referenced this issue Mar 22, 2019
@kaiiam
modify ebi_biomes.csv
03c3c2c 
Addressing  PR #735 and issue  #672 I have proposed the following changes. Please merge if correct or modify.
@kaiiam kaiiam mentioned this issue Mar 22, 2019
Closed
kaiiam added a commit that referenced this issue Apr 28, 2019
@kaiiam
Remake PR #736 to fix ebi_biomes.csv
623c0cd 
Due to merge conflicts, I will remake  remake PR #736 here in to address PR #735 and issue #672.
@kaiiam kaiiam mentioned this issue Apr 28, 2019
Merged
@kaiiam
Copy link
Contributor Author

kaiiam commented Apr 29, 2019

Addressed with PR #736

@kaiiam kaiiam closed this as completed Apr 29, 2019
@kaiiam kaiiam added the GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmungall cmungall

Labels
GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmungall @kaiiam