You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I find it very inconsistent to have a notBefore parameter but not a notAfter and then the true notAfter is calculated from the clumsy integer days parameter.
With the current parameters there is no way to have a validity from right now (the time the cert was created) to a clean future date such as: 2026-01-01 00:00:00.
I suggest either removing the 'days' parameter entirely and just having a notAfter parameter. I think this is the best and cleanest solution but it would be a breaking change.
Alternatively you could offer both and adding an assert if both are specified?
If you want to go ahead I'm more than happy to implement and send a PR.
The text was updated successfully, but these errors were encountered:
@jimmyff
Feel free to propose a solution for that. Keep in mind the code should be backwards compatible. I took a quick look and would suggest to create a new method.
I find it very inconsistent to have a
notBefore
parameter but not anotAfter
and then the truenotAfter
is calculated from the clumsy integerdays
parameter.With the current parameters there is no way to have a validity from right now (the time the cert was created) to a clean future date such as: 2026-01-01 00:00:00.
I suggest either removing the 'days' parameter entirely and just having a notAfter parameter. I think this is the best and cleanest solution but it would be a breaking change.
Alternatively you could offer both and adding an assert if both are specified?
If you want to go ahead I'm more than happy to implement and send a PR.
The text was updated successfully, but these errors were encountered: