Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the CLI config format for the VS extension #2765

Open
ErikEJ opened this issue Jan 6, 2025 · 0 comments
Open

Consider using the CLI config format for the VS extension #2765

ErikEJ opened this issue Jan 6, 2025 · 0 comments
Labels

Comments

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 6, 2025

Now that most features are supported by the CLI, we could consider using the CLI config format instead of the efpt.config.json format.

WHY?

  • the new format is much more readable, and recently "tooltip" support was added for it in VS.
  • this will also light up the object filtering available in the CLI config file.

Missing features

                // Not supported:
                UseHandleBars = false,
                SelectedHandlebarsLanguage = 0, // handlebars support, will not support it
                OptionsPath = null, // handlebars support, will not support it (looks like it is not used!)

                // Not implemented:
                UseNoDefaultConstructor = false, // not implemented, will consider if asked for
                DefaultDacpacSchema = null, // not implemented, will consider if asked for
                UseNoObjectFilter = false, // will always add all objects and use exclusions to filter list (for now)
                UseAsyncCalls = true, // not implemented
                FilterSchemas = false, // not implemented
                Schemas = null, // not implemented

Design thoughts:

We already have a method (mapper) to convert a CLI config file to ReverseEngineeerOptions used by the VS extension.

If there is only a single efpt.config.json file in the project, we could silently just save using the CLI format, and get rid of the old file (rename to .bak)

If there are more eftp.config.json files, leave everything as is.

Add global option to opt out of this, to stay on the old format (for now)

We could also decide to not convert if any of the not supported/not implemented features are in use.

@jwyza-pi FYI!

@ErikEJ ErikEJ added enhancement New feature or request reveng reveng-cli labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant