From 80c3150e44f7ff06afb524e86e8d5d0e8aa90a9c Mon Sep 17 00:00:00 2001 From: Josh Roy <10731363+JRoy@users.noreply.github.com> Date: Sun, 21 Jul 2024 17:48:16 -0400 Subject: [PATCH] Fix trade signs not updating signs (Fixes #5814) i guess these things are transactional now whatever --- .../java/com/earth2me/essentials/signs/EssentialsSign.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java b/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java index 39921ee3f4f..97cac9e5b3d 100644 --- a/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java +++ b/Essentials/src/main/java/com/earth2me/essentials/signs/EssentialsSign.java @@ -550,9 +550,11 @@ public void updateSign() { static class BlockSign implements ISign { private final transient Block block; + private transient Sign sign; BlockSign(final Block block) { this.block = block; + this.sign = getSign(); } @Override @@ -569,7 +571,7 @@ public final String getLine(final int index) { @Override public final void setLine(final int index, final String text) { - getSign().setLine(index, text); + sign.setLine(index, text); updateSign(); } @@ -586,7 +588,8 @@ private Sign getSign() { @Override public final void updateSign() { - getSign().update(); + sign.update(); + sign = getSign(); } } }