Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextRow (when used in SplitRow) is not able to render Korean string correctly #38

Open
karansota opened this issue Sep 18, 2019 · 5 comments

Comments

@karansota
Copy link

SplitRow<TextRow, LocationRow> { $0.rowLeftPercentage = 0.65 $0.rowLeft = TextRow("locationText") { $0.placeholder = placeholder if let name = value?.name { $0.value = name } if isDisabled { $0.disabled = true } } $0.rowRight = LocationRow("locationLookup") { $0.shouldDisplayValue = false $0.title = title if let value = value { $0.value = value } else { $0.value = Place(address: nil, coordinates: nil, name: nil) } if isDisabled { $0.disabled = true } } }

Actual String when user types into the TextRow: 시ㅇ
Expected String: 설 (above characters should build this string)

Screen Shot 2019-09-17 at 10 29 41 PM

@karansota karansota changed the title TextRow is not able to render Korean string correctly TextRow (when used in SplitRow) is not able to render Korean string correctly Sep 18, 2019
@karansota
Copy link
Author

TextRow when used by itself has no issues.

@marbetschar
Copy link
Collaborator

marbetschar commented Sep 20, 2019

@karansota wow, nice catch! I wasn't even aware of the fact, that input character conversion exists at all! :) - altough it makes perfectly sense if you think about it.

My buest guess as of now is that there is some sort of conversion-triggered-re-rendering of the underlying UITextField which gets lost somewhere on its way. Will need some time figure out what exactly causes this unexpected behaviour.

Any chance you can confirm the same (wrong) behaviour for the TextAreaRow?

@marbetschar
Copy link
Collaborator

@mats-claassen do you have any experience with this? I don't know how UITextField works under the hood to render Asian text where the user input is not the actual rendered text.

Maybe you have some tips on where to start and/or why this basically works in TextRow, but only if it is not embedded in a SplitRow?

@mats-claassen
Copy link
Member

@mats-claassen do you have any experience with this? I don't know how UITextField works under the hood to render Asian text where the user input is not the actual rendered text.

No, I haven't. My suggestion would be to see what SplitRows does that might change how a TextRow works inside. Maybe it has to do with #39 but that is only a wild guess

@yk4to
Copy link

yk4to commented May 13, 2020

The same problem occurred when I typed in Japanese.
The suggestion appears above the keyboard when using TextRow by itself, but not in the TextRow in SplitRow.
(I think this problem is as inconvenience as I can only enter uppercase letters when I want to enter the alphabet, to me.)
Is there a solution?
IMG_5913 (1) IMG_5914 (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants