Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No route - repeat swap attempt #1004

Closed
offerm opened this issue Jun 2, 2019 · 7 comments
Closed

No route - repeat swap attempt #1004

offerm opened this issue Jun 2, 2019 · 7 comments
Labels
101-250 XUC bug Something isn't working P2 mid priority swaps

Comments

@offerm
Copy link
Contributor

offerm commented Jun 2, 2019

test2 node does not have an LTC channels. Sanity swap is off.

Order is

xud@xud-test-2:~$ xucli sell 0.001 LTC/BTC 0.0077 
failed to swap 0.001 LTC with peer order 59504a20-8576-11e9-8772-b1e9a3fc91a3
remaining 0.001 LTC entered the order book as b51099f0-8576-11e9-8035-ede487fe967d

Log shows (total 4478 times):

02/06/2019 20:40:50.191 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.198 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 5950
4a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.222 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.223 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.224 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.225 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.226 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.232 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.233 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.234 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.240 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.241 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.247 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.248 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.249 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.249 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.250 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.256 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.257 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.257 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.258 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.258 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.263 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.264 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.264 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.265 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.265 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.270 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.270 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.271 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.271 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.272 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:40:50.276 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:40:50.277 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:40:50.278 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:40:50.278 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:40:50.279 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
...
...
...
...
02/06/2019 20:41:00.182 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:41:00.183 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:41:00.183 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:41:00.183 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:41:00.183 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:41:00.185 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:41:00.186 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:41:00.186 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:41:00.186 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:41:00.186 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:41:00.188 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:41:00.188 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:41:00.189 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:41:00.189 [ORDERBOOK] debug: reduced order 59504a20-8576-11e9-8772-b1e9a3fc91a3 by 100000 quantity while matching order b51099f0-8576-11e9-8035-ede487fe967d
02/06/2019 20:41:00.189 [ORDERBOOK] debug: matched with peer 02b66438730d1fcdf4a4ae5d3d73e847a272f160fee2938e132b52cab0a0d9cfc6, executing swap on taker b51099f0-8576-11e9-8035-ede487fe967d and maker 59504a20-8576-11e9-8772-b1e9a3fc91a3 for 100000
02/06/2019 20:41:00.191 [ORDERBOOK] error: swap between orders 59504a20-8576-11e9-8772-b1e9a3fc91a3 & b51099f0-8576-11e9-8035-ede487fe967d failed due to NoRouteFound
02/06/2019 20:41:00.191 [ORDERBOOK] warn: swap for 100000 failed during order matching due to NoRouteFound, will repeat matching routine for failed quantity
02/06/2019 20:41:00.192 [ORDERBOOK] debug: repeating matching routine for b51099f0-8576-11e9-8035-ede487fe967d for failed quantity of 100000
02/06/2019 20:41:00.192 [ORDERBOOK] debug: placeOrder max time exceeded. order ({"pairId":"LTC/BTC","price":0.0077,"quantity":100000,"isBuy":false,"localId":"b51099f0-8576-11e9-8035-ede487fe967d","hold":0,"id":"b51099f0-8576-11e9-8035-ede487fe967d","initialQuantity":100000,"createdAt":1559508050191}) won't be fully matched
02/06/2019 20:41:00.209 [ORDERBOOK] debug: order added: {"pairId":"LTC/BTC","price":0.0077,"quantity":100000,"isBuy":false,"localId":"b51099f0-8576-11e9-8035-ede487fe967d","hold":0,"id":"b51099f0-8576-11e9-8035-ede487fe967d","initialQuantity":100000,"createdAt":1559508050191}
@ghost ghost added bug Something isn't working swaps P2 mid priority labels Jun 4, 2019
@sangaman
Copy link
Collaborator

sangaman commented Jun 4, 2019

I'm not sure this is exactly a "bug" per se, this is the intended behavior currently even though it's certainly not ideal. I think this relates to #684, and basically we need to more intelligently handle repeated routing/payment failures with a particular peer and go the route of deactivating pairs. The tricky part is that without sanity swaps, I'm not sure when we'd determine when to reactive a pair with a peer. Maybe, even if nosanitychecks is set, we use sanity swaps only when determining when to reactivate pairs - so we start with pairs active by default without a sanity swap to start.

@kilrau
Copy link
Contributor

kilrau commented Jun 5, 2019

Sanity swap is off

Do you mean sanitychecks=false? If so, this also switches off @erkarl 's sanity checks on place order which would have caught this one. @offerm

@offerm
Copy link
Contributor Author

offerm commented Jun 5, 2019 via email

@kilrau
Copy link
Contributor

kilrau commented Jun 6, 2019

Also, maybe we should not hide all checks behind the same flag to allow turning them ON separately

Had the same thought. But since this a debug feature, we might want to hide this somewhere in debug or developer config category which is clearly marked as "Don't touch, if you don't know what you are doing!"

@kilrau
Copy link
Contributor

kilrau commented Jun 7, 2019 •
edited
Loading

Hmm sounds like we should fix this since we default sanitychecks=false. Volunteers? e.g. @ImmanuelSegol ?

@kilrau kilrau modified the milestones: 1.0.0, 1.0.0-beta, 1.0.0-testnet Jun 7, 2019
@kilrau kilrau assigned ghost Jun 11, 2019
@kilrau
Copy link
Contributor

kilrau commented Jun 11, 2019

Lucky you! @erkarl

@kilrau kilrau removed this from the 1.0.0-beta milestone Jun 11, 2019
@kilrau kilrau unassigned ghost Oct 31, 2019
@engwarrior
Copy link
Contributor

Pls provide estimate for this task.

@kilrau kilrau closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
101-250 XUC bug Something isn't working P2 mid priority swaps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sangaman @offerm @kilrau @engwarrior