Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Spring from the Kafka Notifier app #367

Open
williewheeler opened this issue Feb 19, 2019 · 0 comments
Open

Remove Spring from the Kafka Notifier app #367

williewheeler opened this issue Feb 19, 2019 · 0 comments
Labels
cleanup Basic code cleanup, short of refactoring good first issue Good for newcomers

Comments

@williewheeler
Copy link
Contributor

In general we would prefer not to use Spring for the Kafka Streams apps, as these are pretty lightweight and don't really warrant pulling Spring in. The Notifier app is currently based on Spring Boot. We would like to remove Spring from this particular app.
@williewheeler williewheeler added cleanup Basic code cleanup, short of refactoring good first issue Good for newcomers labels Feb 19, 2019
@williewheeler williewheeler self-assigned this Feb 20, 2019
williewheeler added a commit that referenced this issue Feb 20, 2019
@williewheeler
Wrote KafkaMultiClusterAnomalyToMetricMapper unit test (#372)
e52ab70 
This involved creating some JSON-based serializers and deserializers,
along with their corresponding unit tests.

Also, I used kafka-junit to implement the unit a2m mapper unit test. After
doing so I noticed an interaction between the mock broker I am using and
the mock broker that the notifier app is using. I am not sure exactly what
the interaction is at this point, but I suspect it may be related to
the notifier tests setting system properties. Again that's just a guess.
At any rate I simply disabled the unit tests for the two notifier classes
as issue #367 is to remove Spring from the notifier. I will pick that
issue up after this one and see if that eliminates the interaction.

Finally please see my comments around JsonPojoSerde and the related
serializer and deserializer. I deprecated these. I explain in a comment in
JsonPojoDeserializer.
@williewheeler williewheeler mentioned this issue Feb 20, 2019
Merged
@williewheeler williewheeler removed their assignment Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Basic code cleanup, short of refactoring good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williewheeler