-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reports - Chat name is not wrapped properly when report name is long and has no limit #56529
Comments
Triggered auto assignment to @dylanexpensify ( |
Triggered auto assignment to @techievivek ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.When the report name is long, the line is not wrapped correctly. What is the root cause of that problem?We don't pass App/src/components/SelectionList/ChatListItem.tsx Lines 106 to 111 in 33a03bf
What changes do you think we should make in order to solve the problem?We should add props App/src/components/SelectionList/ChatListItem.tsx Lines 106 to 111 in 33a03bf
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Regression PR: #50135 |
An edge case IMO, so we can remove the blocker label and let the author fix this as a followup. |
Job added to Upwork: https://www.upwork.com/jobs/~021887868925117012182 |
Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new. |
I don't think we need to have any compensation here since it's a followup to another PR they worked on #50135 |
Hi, can you assign me? I’ll take care of it today :) |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
In the PR I've just modified the component so it is wrapped when the name is too long. However I’m wondering if this use case matches what we expected. The parent message shows as a name instead of the person's name because, we check if message is a thread and what the What do you think @luacmartins? Now I see that there is also an issue about it #56530 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search
Action Performed:
Expected Result:
Actual Result:
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/c88b1c2e-4daa-41af-be4b-a4eaa47d4561View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: