Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports - Chat name is not wrapped properly when report name is long and has no limit #56529

Open
6 of 8 tasks
IuliiaHerets opened this issue Feb 7, 2025 · 13 comments
Open
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 7, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to DM.
  3. Send a long message with some spaces between words.
  4. Long tap on the message > Reply in thread.
  5. Send a reply in thread.
  6. Go to Reports.
  7. Tap on the dropdown.
  8. Select Chats.

Expected Result:

  • When the report name is long, the line should be wrapped correctly.
  • Long room name should be limited to two lines.

Actual Result:

  • When the report name is long, the line is not wrapped correctly.
  • Long room name is not limited to a few lines.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image https://github.com/user-attachments/assets/c88b1c2e-4daa-41af-be4b-a4eaa47d4561

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021887868925117012182
  • Upwork Job ID: 1887868925117012182
  • Last Price Increase: 2025-02-07
  • Automatic offers:
    • DylanDylann | Reviewer | 106038637
Issue OwnerCurrent Issue Owner: @
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkdengineer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the report name is long, the line is not wrapped correctly.
Long room name is not limited to a few lines.

What is the root cause of that problem?

We don't pass numberOfLines to this text link

<TextLink
fontSize={variables.fontSizeSmall}
onPress={() => onSelectRow(item)}
>
{reportActionItem.reportName}
</TextLink>

What changes do you think we should make in order to solve the problem?

We should add props numberOfLines={2}

<TextLink
fontSize={variables.fontSizeSmall}
onPress={() => onSelectRow(item)}
>
{reportActionItem.reportName}
</TextLink>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Feb 7, 2025

Regression PR: #50135

@techievivek
Copy link
Contributor

An edge case IMO, so we can remove the blocker label and let the author fix this as a followup.

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 7, 2025
@techievivek techievivek added the External Added to denote the issue can be worked on by a contributor label Feb 7, 2025
@melvin-bot melvin-bot bot changed the title Reports - Chat name is not wrapped properly when report name is long and has no limit [$250] Reports - Chat name is not wrapped properly when report name is long and has no limit Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021887868925117012182

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@techievivek techievivek changed the title [$250] Reports - Chat name is not wrapped properly when report name is long and has no limit Reports - Chat name is not wrapped properly when report name is long and has no limit Feb 7, 2025
@techievivek
Copy link
Contributor

I don't think we need to have any compensation here since it's a followup to another PR they worked on #50135

@zfurtak
Copy link
Contributor

zfurtak commented Feb 7, 2025

Hi, can you assign me? I’ll take care of it today :)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@luacmartins luacmartins self-assigned this Feb 8, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 9, 2025
@zfurtak
Copy link
Contributor

zfurtak commented Feb 9, 2025

In the PR I've just modified the component so it is wrapped when the name is too long.

However I’m wondering if this use case matches what we expected. The parent message shows as a name instead of the person's name because, we check if message is a thread and what the policy.name is. But in this case, there’s no policy.name so the result is from getReportName function.

What do you think @luacmartins?

Now I see that there is also an issue about it #56530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants