Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system message to come from Expensify for ACTIONABLEJOINREQUEST action name #56534

Open
hoangzinh opened this issue Feb 7, 2025 · 3 comments
Open

Update system message to come from Expensify for ACTIONABLEJOINREQUEST action name #56534

hoangzinh opened this issue Feb 7, 2025 · 3 comments
Assignees
@AndrewGable
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@hoangzinh
Copy link
Contributor

Original GH:

#51069

Follow up of this request: #51843 (comment)

Action Performed:

Break down in numbered steps

  1. Log in as user A
  2. Go to workspace settings
  3. Click "share" and copy the URL
  4. Open the URL and login with different account user B
  5. Log in back to user A and go to #admin room of the workspace

Expected Result:

BE returns action ACTIONABLEJOINREQUEST with actorAccountID, avatar and person of Expensify

#51843 (comment)

Actual Result:

BE returns action ACTIONABLEJOINREQUEST with actorAccountID, avatar and person of user B

Screenshots/Videos

Add any screenshot/video evidence

Image
@hoangzinh hoangzinh added AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 7, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @puneetlath (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Feb 7, 2025
@hoangzinh
Copy link
Contributor Author

cc @AndrewGable @nkdengineer

@hoangzinh
Copy link
Contributor Author

Coming from this Slack discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1738881725480679?thread_ts=1738833186.139009&cid=C01GTK53T8Q. This is the first time I created an issue. Feel free to update if something is incorrect. Thank you cc @puneetlath @AndrewGable

@AndrewGable AndrewGable assigned AndrewGable and unassigned puneetlath Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewGable AndrewGable

Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@puneetlath @AndrewGable @hoangzinh